[
https://issues.apache.org/jira/browse/HDFS-14687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903607#comment-16903607
]
Siyao Meng commented on HDFS-14687:
-----------------------------------
[~surendrasingh] Great work. Thanks for the patch. The fix looks good to me.
Unit test passed locally.
Just two minor issues:
1. Please address the checkstyle
[warnings|https://builds.apache.org/job/PreCommit-HDFS-Build/27409/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt]
(line length).
2. Could you replace Thread.sleep(4000) in the test with either:
(1) another method that doesn't rely on timing, like what is done in
[HDFS-10240|https://github.com/apache/hadoop/commit/1290e3c647092f0bfbb250731a6805aba1be8e4b#diff-e069dc77becb87b909a07d27d3525236R1338];
(2) use a loop with small intervals (e.g. 100 ms) to check the status of
DataNode IBR until it finishes;
BTW I tried to remove Thread.sleep(4000) and ran the test. It passed as well
(locally on my Mac). Is this sleep() call necessarily? Please remove if not.
> Standby Namenode never come out of safemode when EC files are being written.
> ----------------------------------------------------------------------------
>
> Key: HDFS-14687
> URL: https://issues.apache.org/jira/browse/HDFS-14687
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ec, namenode
> Affects Versions: 3.1.1
> Reporter: Surendra Singh Lilhore
> Assignee: Surendra Singh Lilhore
> Priority: Critical
> Attachments: HDFS-14687.001.patch, HDFS-14687.002.patch
>
>
> When huge number of EC files are being written and SBN is restarted then it
> will never come out of safe mode and required blocks count getting increase.
> {noformat}
> The reported blocks 16658401 needs additional 1702 blocks to reach the
> threshold 0.99999 of total blocks 16660120.
> The reported blocks 16658659 needs additional 2935 blocks to reach the
> threshold 0.99999 of total blocks 16661611.
> The reported blocks 16659947 needs additional 3868 blocks to reach the
> threshold 0.99999 of total blocks 16663832.
> The reported blocks 16666335 needs additional 5116 blocks to reach the
> threshold 0.99999 of total blocks 16671468.
> The reported blocks 16669311 needs additional 6384 blocks to reach the
> threshold 0.99999 of total blocks 16675712.
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
