[
https://issues.apache.org/jira/browse/HDDS-1596?focusedWorklogId=296509&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296509
]
ASF GitHub Bot logged work on HDDS-1596:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Aug/19 19:08
Start Date: 16/Aug/19 19:08
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #861: HDDS-1596. Create
service endpoint to download configuration from SCM
URL: https://github.com/apache/hadoop/pull/861#issuecomment-522119175
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 42 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 1 | No case conflicting files found. |
| 0 | yamllint | 0 | yamllint was not available. |
| 0 | shelldocs | 0 | Shelldocs was not available. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 1 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 27 | Maven dependency ordering for branch |
| +1 | mvninstall | 562 | trunk passed |
| +1 | compile | 367 | trunk passed |
| +1 | checkstyle | 76 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 785 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 163 | trunk passed |
| 0 | spotbugs | 451 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 662 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 38 | Maven dependency ordering for patch |
| +1 | mvninstall | 589 | the patch passed |
| +1 | compile | 388 | the patch passed |
| +1 | javac | 388 | the patch passed |
| -0 | checkstyle | 39 | hadoop-hdds: The patch generated 1 new + 0
unchanged - 0 fixed = 1 total (was 0) |
| -0 | checkstyle | 41 | hadoop-ozone: The patch generated 1 new + 0
unchanged - 0 fixed = 1 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| +1 | shellcheck | 0 | There were no new shellcheck issues. |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 3 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 655 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 155 | the patch passed |
| +1 | findbugs | 681 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 305 | hadoop-hdds in the patch failed. |
| -1 | unit | 1720 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 48 | The patch does not generate ASF License warnings. |
| | | 7584 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdds.scm.block.TestBlockManager |
| | hadoop.ozone.TestStorageContainerManager |
| | hadoop.ozone.TestSecureOzoneCluster |
| | hadoop.ozone.client.rpc.Test2WayCommitInRatis |
| | hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-861/9/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/861 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle xml yamllint shellcheck shelldocs
|
| uname | Linux e68565849e6b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / e356e4f |
| Default Java | 1.8.0_212 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-861/9/artifact/out/diff-checkstyle-hadoop-hdds.txt
|
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-861/9/artifact/out/diff-checkstyle-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-861/9/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-861/9/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-861/9/testReport/ |
| Max. process+thread count | 5267 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds hadoop-hdds/common hadoop-hdds/container-service
hadoop-hdds/framework hadoop-hdds/server-scm hadoop-ozone/dist
hadoop-ozone/ozone-manager hadoop-ozone/ozonefs hadoop-ozone/s3gateway U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-861/9/console |
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.4.6 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 296509)
Time Spent: 2h 40m (was: 2.5h)
> Create service endpoint to download configuration from SCM
> ----------------------------------------------------------
>
> Key: HDDS-1596
> URL: https://issues.apache.org/jira/browse/HDDS-1596
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> As written in the design doc (see the parent issue) it was proposed to
> download the configuration from the scm by the other services.
> I propose to create a separated endpoint to provide the ozone configuration.
> /conf can't be used as it contains *all* the configuration and we need only
> the modified configuration.
> The easiest way to implement this feature is:
> * Create a simple rest endpoint which publishes all the configuration
> * Download the configurations to $HADOOP_CONF_DIR/ozone-global.xml during
> the service startup.
> * Add ozone-global.xml as an additional config source (before ozone-site.xml
> but after ozone-default.xml)
> * The download can be optional
> With this approach we keep the support of the existing manual configuration
> (ozone-site.xml has higher priority) but we can download the configuration to
> a separated file during the startup, which will be loaded.
> There is no magic: the configuration file is saved and it's easy to debug
> what's going on as the OzoneConfiguration is loaded from the $HADOOP_CONF_DIR
> as before.
> Possible follow-up steps:
> * Migrate all the other services (recon, s3g) to the new approach. (possible
> newbie jiras)
> * Improve the CLI to define the SCM address. (As of now we use
> ozone.scm.names)
> * Create a service/hostname registration mechanism and autofill some of the
> configuration based on the topology information.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
