[ https://issues.apache.org/jira/browse/HDFS-14523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16909521#comment-16909521 ]
Hudson commented on HDFS-14523: ------------------------------- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17138 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/17138/]) HDFS-14523. Remove excess read lock for NetworkToplogy. Contributed by (weichiu: rev 971a4c8e8328a4bdea65de4a0e84c82b5b2de24b) * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java > Remove excess read lock for NetworkToplogy > ------------------------------------------ > > Key: HDFS-14523 > URL: https://issues.apache.org/jira/browse/HDFS-14523 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Wu Weiwei > Assignee: Wu Weiwei > Priority: Major > Fix For: 3.3.0 > > Attachments: HDFS-14523.1.patch > > > getNumOfRacks() and getNumOfLeaves() are two high frequencies call methods > for BlockPlacementPolicy, this two methods need to get NetworkTopology read > lock, and get lock in high frequencies call methods may impact the namenode > performance. > This two methods get number of racks and number of leaves just for > chooseTarget calculate, lock in these two methods cannot guarantee these two > values will not change in the subsequent calculations. > I think it's safe to remove the read lock from this two methods. -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org