[
https://issues.apache.org/jira/browse/HDDS-1946?focusedWorklogId=296884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296884
]
ASF GitHub Bot logged work on HDDS-1946:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Aug/19 05:14
Start Date: 18/Aug/19 05:14
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1311:
HDDS-1946. CertificateClient should not persist keys/certs to ozone.m…
URL: https://github.com/apache/hadoop/pull/1311#discussion_r314968409
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/DNCertificateClient.java
##########
@@ -25,20 +25,26 @@
import org.slf4j.LoggerFactory;
import org.apache.hadoop.hdds.security.x509.SecurityConfig;
+
+import java.nio.file.Paths;
+
/**
* Certificate client for DataNodes.
*/
public class DNCertificateClient extends DefaultCertificateClient {
private static final Logger LOG =
LoggerFactory.getLogger(DNCertificateClient.class);
+
+ public static final String COMPONENT_NAME = Paths.get("dn").toString();
Review comment:
Minor NIT: Here we can use directly assign the component name, instead of
calling Paths.get("dn").toString(). As this also just returns "dn".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 296884)
Time Spent: 1h (was: 50m)
> CertificateClient should not persist keys/certs to ozone.metadata.dir
> ---------------------------------------------------------------------
>
> Key: HDDS-1946
> URL: https://issues.apache.org/jira/browse/HDDS-1946
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Xiaoyu Yao
> Assignee: Vivek Ratnavel Subramanian
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> For example, when OM and SCM are deployed on the same host with
> ozone.metadata.dir defined. SCM can start successfully but OM can not because
> the key/cert from OM will collide with SCM.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
