[ https://issues.apache.org/jira/browse/HDFS-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911519#comment-16911519 ]
Íñigo Goiri commented on HDFS-14583: ------------------------------------ For this JIRA, the unit test is good. However, I would take the opportunity and extend the coverage here. Let's test a couple of these values here and the full toString(). > FileStatus#toString() will throw IllegalArgumentException > --------------------------------------------------------- > > Key: HDFS-14583 > URL: https://issues.apache.org/jira/browse/HDFS-14583 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: xuzq > Assignee: xuzq > Priority: Major > Labels: HDFS > Attachments: HDFS-14583-trunk-0001.patch, HDFS-14583-trunk-002.patch > > > FileStatus#toString() will throw IllegalArgumentException, stack and error > message like this: > {code:java} > java.lang.IllegalArgumentException: Can not create a Path from an empty string > at org.apache.hadoop.fs.Path.checkPathArg(Path.java:172) > at org.apache.hadoop.fs.Path.<init>(Path.java:184) > at > org.apache.hadoop.hdfs.protocol.HdfsLocatedFileStatus.getSymlink(HdfsLocatedFileStatus.java:117) > at org.apache.hadoop.fs.FileStatus.toString(FileStatus.java:462) > at > org.apache.hadoop.hdfs.web.TestJsonUtil.testHdfsFileStatus(TestJsonUtil.java:123) > {code} > Test Code like this: > {code:java} > @Test > public void testHdfsFileStatus() throws IOException { > HdfsFileStatus hdfsFileStatus = new HdfsFileStatus.Builder() > .replication(1) > .blocksize(1024) > .perm(new FsPermission((short) 777)) > .owner("owner") > .group("group") > .symlink(new byte[0]) > .path(new byte[0]) > .fileId(1010) > .isdir(true) > .build(); > System.out.println("HdfsFileStatus = " + hdfsFileStatus.toString()); > }{code} > -- This message was sent by Atlassian Jira (v8.3.2#803003) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org