[
https://issues.apache.org/jira/browse/HDDS-1610?focusedWorklogId=298678&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298678
]
ASF GitHub Bot logged work on HDDS-1610:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/19 13:29
Start Date: 21/Aug/19 13:29
Worklog Time Spent: 10m
Work Description: cawatson commented on pull request #1226: HDDS-1610.
applyTransaction failure should not be lost on restart.
URL: https://github.com/apache/hadoop/pull/1226#discussion_r316184455
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestContainerStateMachineFailures.java
##########
@@ -179,22 +194,6 @@ public void testContainerStateMachineFailures() throws
Exception {
.getDatanodeStateMachine().getContainer();
Assert
.assertNull(ozoneContainer.getContainerSet().getContainer(containerID));
-
- OzoneKeyDetails keyDetails = objectStore.getVolume(volumeName)
- .getBucket(bucketName).getKey("ratis");
-
- /**
- * Ensure length of data stored in key is equal to number of bytes written.
- */
- Assert.assertTrue("Number of bytes stored in the key is not equal " +
- "to number of bytes written.", keyDetails.getDataSize() == written);
-
- /**
- * Pending data from the second write should get written to a new container
- * during key.close() because the first container is UNHEALTHY by that time
- */
- Assert.assertTrue("Expect Key to be stored in 2 separate containers",
- keyDetails.getOzoneKeyLocations().size() == 2);
}
Review comment:
I am creating a tool to aid developers by partially automating unti testing.
Could you speak to the validity of these generated assert statement for the
given test method?
`org.junit.Assert.assertEquals( HddsProtos.getHddsDatanodes( result ),
groupOutputStream);`
`org.junit.Assert.assertEquals( OmKeyLocationInfo.getHddsDatanodes(),
groupOutputStream.getHddsDatanodes( rs ));`
`org.junit.Assert.assertEquals( OmKeyLocationInfo.getHddsDatanodes(),
groupOutputStream.getHddsDatanodes( groupOutputStream ));`
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 298678)
Time Spent: 6.5h (was: 6h 20m)
> applyTransaction failure should not be lost on restart
> ------------------------------------------------------
>
> Key: HDDS-1610
> URL: https://issues.apache.org/jira/browse/HDDS-1610
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> If the applyTransaction fails in the containerStateMachine, then the
> container should not accept new writes on restart,.
> This can occur if
> # chunk write applyTransaction fails
> # container state update to UNHEALTHY also fails
> # Ratis snapshot is taken
> # Node restarts
> # container accepts new transactions
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
