[ 
https://issues.apache.org/jira/browse/HDDS-2030?focusedWorklogId=301733&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301733
 ]

ASF GitHub Bot logged work on HDDS-2030:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Aug/19 06:33
            Start Date: 27/Aug/19 06:33
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on pull request #1348: 
HDDS-2030. Generate simplifed reports by the dev-support/checks/*.sh scripts
URL: https://github.com/apache/hadoop/pull/1348#discussion_r317913589
 
 

 ##########
 File path: hadoop-ozone/dev-support/checks/integration.sh
 ##########
 @@ -20,10 +20,14 @@ export MAVEN_OPTS="-Xmx4096m"
 mvn -B install -f pom.ozone.xml -DskipTests
 mvn -B -fn test -f pom.ozone.xml -pl 
:hadoop-ozone-integration-test,:hadoop-ozone-filesystem,:hadoop-ozone-tools \
   -Dtest=\!TestMiniChaosOzoneCluster
-module_failed_tests=$(find "." -name 'TEST*.xml' -print0 \
-    | xargs -0 -n1 "grep" -l -E "<failure|<error"\
-    | awk -F/ '{sub("'"TEST-JUNIT_TEST_OUTPUT_DIR"'",""); sub(".xml",""); 
print $NF}')
-if [[ -n "${module_failed_tests}" ]] ; then
+
+REPORT_DIR=${OUTPUT_DIR:-"$DIR/../../../target/integration"}
+mkdir -p "$REPORT_DIR"
+
+# shellcheck source=_mvn_unit_report.sh
+source "$DIR/_mvn_unit_report.sh"
 
 Review comment:
   shellcheck:1: note: Not following: _mvn_unit_report.sh: openBinaryFile: does 
not exist (No such file or directory) [SC1091]
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 301733)
    Time Spent: 1h 10m  (was: 1h)

> Generate simplifed reports by the dev-support/checks/*.sh scripts
> -----------------------------------------------------------------
>
>                 Key: HDDS-2030
>                 URL: https://issues.apache.org/jira/browse/HDDS-2030
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: build
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> hadoop-ozone/dev-support/checks directory contains shell scripts to execute 
> different type of code checks (findbugs, checkstyle, etc.)
> Currently the contract is very simple. Every shell script executes one (and 
> only one) check and the shell response code is set according to the result 
> (non-zero code if failed).
> To have better reporting in the github pr build, it would be great to improve 
> the scripts to generate simple summary files and save the relevant files for 
> archiving.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to