[
https://issues.apache.org/jira/browse/HDDS-738?focusedWorklogId=302375&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302375
]
ASF GitHub Bot logged work on HDDS-738:
---------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:44
Start Date: 27/Aug/19 20:44
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1329: HDDS-738.
Removing REST protocol support from OzoneClient
URL: https://github.com/apache/hadoop/pull/1329#issuecomment-525475094
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 40 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 5 | No case conflicting files found. |
| 0 | shelldocs | 0 | Shelldocs was not available. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 48 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 35 | Maven dependency ordering for branch |
| +1 | mvninstall | 614 | trunk passed |
| +1 | compile | 397 | trunk passed |
| +1 | checkstyle | 92 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 785 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 187 | trunk passed |
| 0 | spotbugs | 427 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 626 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 50 | Maven dependency ordering for patch |
| +1 | mvninstall | 539 | the patch passed |
| +1 | compile | 399 | the patch passed |
| +1 | javac | 113 | hadoop-hdds in the patch passed. |
| +1 | javac | 286 | hadoop-ozone generated 0 new + 5 unchanged - 3 fixed =
5 total (was 8) |
| +1 | checkstyle | 101 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | shellcheck | 1 | There were no new shellcheck issues. |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 7 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 694 | patch has no errors when building and testing
our client artifacts. |
| -1 | javadoc | 102 | hadoop-ozone generated 1 new + 26 unchanged - 1 fixed
= 27 total (was 27) |
| +1 | findbugs | 622 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 315 | hadoop-hdds in the patch failed. |
| -1 | unit | 1836 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 64 | The patch does not generate ASF License warnings. |
| | | 7918 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdds.scm.block.TestBlockManager |
| | hadoop.ozone.client.rpc.TestContainerStateMachineFailures |
| | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1329/8/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1329 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle xml shellcheck shelldocs |
| uname | Linux 0e9b74bf9e01 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 66cfa48 |
| Default Java | 1.8.0_222 |
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1329/8/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1329/8/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1329/8/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1329/8/testReport/ |
| Max. process+thread count | 4787 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-ozone hadoop-ozone/client
hadoop-ozone/common hadoop-ozone/datanode hadoop-ozone/dist
hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-ozone/ozonefs
hadoop-ozone/s3gateway hadoop-ozone/tools U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1329/8/console |
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.4.6 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 302375)
Time Spent: 2h 50m (was: 2h 40m)
> Removing REST protocol support from OzoneClient
> -----------------------------------------------
>
> Key: HDDS-738
> URL: https://issues.apache.org/jira/browse/HDDS-738
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Client
> Affects Versions: 0.4.0
> Reporter: Nanda kumar
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Since we have functional {{S3Gateway}} for Ozone which works on REST
> protocol, having REST protocol support in OzoneClient feels redundant and it
> will take a lot of effort to maintain it up to date.
> As S3Gateway is in a functional state now, I propose to remove REST protocol
> support from OzoneClient.
> Once we remove REST support from OzoneClient, the following will be the
> interface to access Ozone cluster
> * OzoneClient (RPC Protocol)
> * OzoneFS (RPC Protocol)
> * S3Gateway (REST Protocol)
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
