[ https://issues.apache.org/jira/browse/HDFS-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918088#comment-16918088 ]
Istvan Fajth edited comment on HDFS-8178 at 8/28/19 8:30 PM: ------------------------------------------------------------- After reviewing the test results, it seems that these test failures are unrelated to the changes, the first one failed on a timeout due to a slower startup of the NameNode than the test expected. The second one seems to be a timing issue in the test, and the JournalNode seems to be starting too quickly and the socket did not got freed up until that point. I am attaching 3 files: * HDFS-8178.008.patch : addressing checkstyle issues in the patch, and review comments by Wei-Chiu, and a refactoring in the test code. * HDFS-8178.008.addendum : addressing all checkstyle issues in the files that are in the patch with a refactoring in the code * HDFS-8178.008.merged: the patch and the addendum merged together was (Author: pifta): After reviewing the test results, it seems that these test failures are unrelated to the changes, the first one failed on a timeout due to a slower startup of the NameNode than the test expected. The second one seems to be a timing issue in the test, and the JournalNode seems to be starting too quickly and the socket did not got freed up until that point. I am attaching 3 files: * HDFS-8178.008.patch : addressing checkstyle issues in the patch, and review comments by Wei-Chiu, and a refactoring in the test code. * HDFS-8178.008.addendum : addressing all checkstyle issues in the files that are in the patch * HDFS-8178.008.merged: the patch and the addendum merged together > QJM doesn't move aside stale inprogress edits files > --------------------------------------------------- > > Key: HDFS-8178 > URL: https://issues.apache.org/jira/browse/HDFS-8178 > Project: Hadoop HDFS > Issue Type: Bug > Components: qjm > Reporter: Zhe Zhang > Assignee: Istvan Fajth > Priority: Major > Labels: BB2015-05-TBR > Attachments: HDFS-8178.000.patch, HDFS-8178.002.patch, > HDFS-8178.003.patch, HDFS-8178.004.patch, HDFS-8178.005.patch, > HDFS-8178.006.patch, HDFS-8178.007.patch, HDFS-8178.008.addendum, > HDFS-8178.008.merged, HDFS-8178.008.patch > > > When a QJM crashes, the in-progress edit log file at that time remains in the > file system. When the node comes back, it will accept new edit logs and those > stale in-progress files are never cleaned up. QJM treats them as regular > in-progress edit log files and tries to finalize them, which potentially > causes high memory usage. This JIRA aims to move aside those stale edit log > files to avoid this scenario. -- This message was sent by Atlassian Jira (v8.3.2#803003) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org