[
https://issues.apache.org/jira/browse/HDFS-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142509#comment-13142509
]
jirapos...@reviews.apache.org commented on HDFS-1580:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2672/
-----------------------------------------------------------
(Updated 2011-11-02 20:54:27.126053)
Review request for hadoop-hdfs.
Summary
-------
This is the final piece to allow the loading of custom implementations of
JournalManager. There is another change HDFS-2334 which adds closeable to
JournalManager, but that may not be absolutely necessary for all journal types.
(it is for bookkeeper)
There's 2 changes:
1) I've changes the interfaces(JournalManager, EditLogInputStream &
EditLogOutputStream) so that they can be implemented outside of the
org.apache.hadoop.hdfs.server.namenode.
2) Pluggable creation of journal managers.
When FSEditLog is creating JournalManagers from dfs.namenode.edits.dir, and it
encounters a URI with a schema different to "file" it loads the name of the
implementing class from "dfs.namenode.edits.journal-plugin.<schema>". This
class must implement JournalManager and have a constructor which takes
(Configuration, URI).
This addresses bug HDFS-1580.
http://issues.apache.org/jira/browse/HDFS-1580
Diffs (updated)
-----
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
dd39676
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogBackupInputStream.java
974697d
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogBackupOutputStream.java
067990d
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileInputStream.java
9db7f8a
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java
4780d04
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogInputStream.java
c6f8505
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogOutputStream.java
8681837
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
f80f863
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
991fd08
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
3adb439
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalManager.java
348e3ef
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalSet.java
45b5714
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java
a7fa7fb
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeResourceChecker.java
4d7cfd8
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestGenericJournalConf.java
PRE-CREATION
Diff: https://reviews.apache.org/r/2672/diff
Testing
-------
Thanks,
Ivan
> Add interface for generic Write Ahead Logging mechanisms
> --------------------------------------------------------
>
> Key: HDFS-1580
> URL: https://issues.apache.org/jira/browse/HDFS-1580
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Jitendra Nath Pandey
> Fix For: HA branch (HDFS-1623), 0.24.0
>
> Attachments: EditlogInterface.1.pdf, EditlogInterface.2.pdf,
> EditlogInterface.3.pdf, HDFS-1580+1521.diff, HDFS-1580.diff, HDFS-1580.diff,
> HDFS-1580.diff, HDFS-1580.diff, HDFS-1580.diff, HDFS-1580.diff,
> HDFS-1580.diff, generic_wal_iface.pdf, generic_wal_iface.pdf,
> generic_wal_iface.pdf, generic_wal_iface.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
