[ https://issues.apache.org/jira/browse/HDDS-1577?focusedWorklogId=305751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-305751 ]
ASF GitHub Bot logged work on HDDS-1577: ---------------------------------------- Author: ASF GitHub Bot Created on: 03/Sep/19 18:10 Start Date: 03/Sep/19 18:10 Worklog Time Spent: 10m Work Description: swagle commented on pull request #1366: HDDS-1577. Add default pipeline placement policy implementation. URL: https://github.com/apache/hadoop/pull/1366#discussion_r320408049 ########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/states/Node2ObjectsMap.java ########## @@ -83,7 +83,7 @@ public void insertNewDatanode(UUID datanodeID, Set<T> containerIDs) * * @param datanodeID - Datanode ID. */ - void removeDatanode(UUID datanodeID) { + public void removeDatanode(UUID datanodeID) { Review comment: Should annotate these methods as @VisibleForTesting ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 305751) Time Spent: 2h (was: 1h 50m) > Add default pipeline placement policy implementation > ---------------------------------------------------- > > Key: HDDS-1577 > URL: https://issues.apache.org/jira/browse/HDDS-1577 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: SCM > Reporter: Siddharth Wagle > Assignee: Li Cheng > Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > This is a simpler implementation of the PipelinePlacementPolicy that can be > utilized if no network topology is defined for the cluster. We try to form > pipelines from existing HEALTHY datanodes randomly, as long as they satisfy > PipelinePlacementCriteria. -- This message was sent by Atlassian Jira (v8.3.2#803003) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org