[ 
https://issues.apache.org/jira/browse/HDDS-2015?focusedWorklogId=306706&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-306706
 ]

ASF GitHub Bot logged work on HDDS-2015:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Sep/19 20:28
            Start Date: 04/Sep/19 20:28
    Worklog Time Spent: 10m 
      Work Description: ajayydv commented on pull request #1386: HDDS-2015. 
Encrypt/decrypt key using symmetric key while writing/reading
URL: https://github.com/apache/hadoop/pull/1386#discussion_r320959255
 
 

 ##########
 File path: 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
 ##########
 @@ -2647,4 +2648,89 @@ private void completeMultipartUpload(OzoneBucket 
bucket, String keyName,
     Assert.assertEquals(omMultipartUploadCompleteInfo.getKey(), keyName);
     Assert.assertNotNull(omMultipartUploadCompleteInfo.getHash());
   }
+
+  /**
+   * Tests GDPR encryption/decryption.
+   * 1. Create GDPR Enabled bucket.
+   * 2. Create a Key in this bucket so it gets encrypted via GDPRSymmetricKey.
+   * 3. Read key and validate the content/metadata is as expected because the
+   * readKey will decrypt using the GDPR Symmetric Key with details from 
KeyInfo
+   * Metadata.
+   * 4. To check encryption, we forcibly update KeyInfo Metadata and remove the
 
 Review comment:
   I am also not sure if metadata updats are exposed to clients via rpc or 
shell. Maybe @anuengineer or @xiaoyuyao can chime in. 
   
   > > Also, this is a test class to simulate that encryption is working.
   
   I am also not talking about this test class but actual BucketImpl class 
which handles bucket metadata operations.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 306706)
    Time Spent: 4h  (was: 3h 50m)

> Encrypt/decrypt key using symmetric key while writing/reading
> -------------------------------------------------------------
>
>                 Key: HDDS-2015
>                 URL: https://issues.apache.org/jira/browse/HDDS-2015
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Dinesh Chitlangia
>            Assignee: Dinesh Chitlangia
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> *Key Write Path (Encryption)*
> When a bucket metadata has gdprEnabled=true, we generate the GDPRSymmetricKey 
> and add it to Key Metadata before we create the Key.
> This ensures that key is encrypted before writing.
> *Key Read Path(Decryption)*
> While reading the Key, we check for gdprEnabled=true and they get the 
> GDPRSymmetricKey based on secret/algorithm as fetched from Key Metadata.
> Create a stream to decrypt the key and pass it on to client.
> *Test*
> Create Key in GDPR Enabled Bucket -> Read Key -> Verify content is as 
> expected -> Update Key Metadata to remove the gdprEnabled flag -> Read Key -> 
> Confirm the content is not as expected.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to