[
https://issues.apache.org/jira/browse/HDDS-1561?focusedWorklogId=306741&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-306741
]
ASF GitHub Bot logged work on HDDS-1561:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/19 21:57
Start Date: 04/Sep/19 21:57
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1401: HDDS-1561: Mark
OPEN containers as QUASI_CLOSED as part of Ratis groupRemove
URL: https://github.com/apache/hadoop/pull/1401#issuecomment-528105007
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 39 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 5 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 72 | Maven dependency ordering for branch |
| +1 | mvninstall | 657 | trunk passed |
| +1 | compile | 396 | trunk passed |
| +1 | checkstyle | 80 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 883 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 185 | trunk passed |
| 0 | spotbugs | 440 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 675 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 41 | Maven dependency ordering for patch |
| +1 | mvninstall | 587 | the patch passed |
| +1 | compile | 414 | the patch passed |
| +1 | javac | 414 | the patch passed |
| -0 | checkstyle | 42 | hadoop-hdds: The patch generated 3 new + 0
unchanged - 0 fixed = 3 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 3 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 683 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 178 | the patch passed |
| +1 | findbugs | 662 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 259 | hadoop-hdds in the patch passed. |
| -1 | unit | 187 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 40 | The patch does not generate ASF License warnings. |
| | | 6315 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.ozone.om.ratis.TestOzoneManagerRatisServer |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1401/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1401 |
| JIRA Issue | HDDS-1561 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle xml |
| uname | Linux 47571461d1a2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 337e9b7 |
| Default Java | 1.8.0_222 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1401/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1401/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1401/1/testReport/ |
| Max. process+thread count | 1293 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds hadoop-hdds/container-service hadoop-ozone
hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1401/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 306741)
Time Spent: 0.5h (was: 20m)
> Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove
> -----------------------------------------------------------------
>
> Key: HDDS-1561
> URL: https://issues.apache.org/jira/browse/HDDS-1561
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode, SCM
> Affects Versions: 0.3.0
> Reporter: Mukul Kumar Singh
> Assignee: Lokesh Jain
> Priority: Blocker
> Labels: pull-request-available
> Attachments: HDDS-1561.001.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Right now, if a pipeline is destroyed by SCM, all the container on the
> pipeline are marked as quasi closed when datanode received close container
> command. SCM while processing these containers reports, marks these
> containers as closed once majority of the nodes are available.
> This is however not a sufficient condition in cases where the raft log
> directory is missing or corrupted. As the containers will not have all the
> applied transaction.
> To solve this problem, we should QUASI_CLOSE the containers in datanode as
> part of ratis groupRemove. If a container is in OPEN state in datanode
> without any active pipeline, it will be marked as Unhealthy while processing
> close container command.
> cc [~jnp], [~shashikant], [~sdeka], [~nandakumar131]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
