[ 
https://issues.apache.org/jira/browse/HDFS-14754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925157#comment-16925157
 ] 

Ayush Saxena edited comment on HDFS-14754 at 9/8/19 12:17 PM:
--------------------------------------------------------------

That seems a little overkill to me. No need to proof that in multiple BR also 
it doesn’t get corrected. IMHO just verifying that your new introduced logic 
now works should be enough.
Anyway, there is a single test, Don't think we need a separate test class for 
it?
May be better if you can use existing test classes. Since the change is in 
BlockManager, can try {{TestBlockManager}} or maybe some other.


was (Author: ayushtkn):
That seems a little overkill to me. No need to proof that in multiple BR also 
it doesn’t get corrected. IMHO just verifying that your new introduced logic 
now works should be enough.

> Erasure Coding :  The number of Under-Replicated Blocks never reduced
> ---------------------------------------------------------------------
>
>                 Key: HDFS-14754
>                 URL: https://issues.apache.org/jira/browse/HDFS-14754
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: hemanthboyina
>            Assignee: hemanthboyina
>            Priority: Critical
>         Attachments: HDFS-14754.001.patch, HDFS-14754.002.patch, 
> HDFS-14754.003.patch, HDFS-14754.004.patch, HDFS-14754.005.patch, 
> HDFS-14754.006.patch
>
>
> Using EC RS-3-2, 6 DN 
> We came accross a scenario where in the EC 5 blocks , same block is 
> replicated thrice and two blocks got missing
> Replicated block was not deleting and missing block is not able to ReConstruct



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to