[
https://issues.apache.org/jira/browse/HDDS-2032?focusedWorklogId=310417&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310417
]
ASF GitHub Bot logged work on HDDS-2032:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/19 08:50
Start Date: 11/Sep/19 08:50
Worklog Time Spent: 10m
Work Description: bshashikant commented on pull request #1420: HDDS-2032.
Ozone client should retry writes in case of any ratis/stateMachine exceptions.
URL: https://github.com/apache/hadoop/pull/1420#discussion_r323127422
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyOutputStream.java
##########
@@ -290,11 +288,12 @@ private void handleException(BlockOutputStreamEntry
streamEntry,
if (!failedServers.isEmpty()) {
excludeList.addDatanodes(failedServers);
}
- if (closedContainerException) {
+
+ // if the container needs to be excluded , add the container to the
+ // exclusion list , otherwise add the pipeline to the exclusion list
+ if (containerExclusionException) {
excludeList.addConatinerId(ContainerID.valueof(containerId));
- } else if (retryFailure || t instanceof TimeoutException
- || t instanceof GroupMismatchException
- || t instanceof NotReplicatedException) {
+ } else {
Review comment:
yes...If dn reports an StorageContainerException , its specific to
containers in dns but other that if ratis reports any other exceptions , it
implies issues in the pipeline itself
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 310417)
Time Spent: 40m (was: 0.5h)
> Ozone client should retry writes in case of any ratis/stateMachine exceptions
> -----------------------------------------------------------------------------
>
> Key: HDDS-2032
> URL: https://issues.apache.org/jira/browse/HDDS-2032
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client
> Affects Versions: 0.5.0
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, Ozone client retry writes on a different pipeline or container in
> case of some specific exceptions. But in case, it sees exception such as
> DISK_FULL, CONTAINER_UNHEALTHY or any corruption , it just aborts the write.
> In general, the every such exception on the client should be a retriable
> exception in ozone client and on some specific exceptions, it should take
> some more specific exception like excluding certain containers or pipelines
> while retrying or informing SCM of a corrupt replica etc.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
