[
https://issues.apache.org/jira/browse/HDDS-2114?focusedWorklogId=312424&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312424
]
ASF GitHub Bot logged work on HDDS-2114:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/19 22:58
Start Date: 13/Sep/19 22:58
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1440: HDDS-2114:
Rename does not preserve non-explicitly created interim directories
URL: https://github.com/apache/hadoop/pull/1440#discussion_r324392898
##########
File path:
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
##########
@@ -374,7 +374,11 @@ public boolean rename(Path src, Path dst) throws
IOException {
}
}
RenameIterator iterator = new RenameIterator(src, dst);
- return iterator.iterate();
+ boolean result = iterator.iterate();
+ if (result) {
+ createFakeParentDirectory(src);
Review comment:
should we createFakeParentDirectory for dst as it is the rename result?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 312424)
Time Spent: 40m (was: 0.5h)
> Rename does not preserve non-explicitly created interim directories
> -------------------------------------------------------------------
>
> Key: HDDS-2114
> URL: https://issues.apache.org/jira/browse/HDDS-2114
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Istvan Fajth
> Assignee: Lokesh Jain
> Priority: Critical
> Labels: pull-request-available
> Attachments: demonstrative_test.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I am attaching a patch that adds a test that demonstrates the problem.
> The scenario is coming from the way how Hive implements acid transactions
> with the ORC table format, but the test is redacted to the simplest possible
> code that reproduces the issue.
> The scenario:
> * Given a 3 level directory structure, where the top level directory was
> explicitly created, and the interim directory is implicitly created (for
> example either by creating a file with create("/top/interim/file") or by
> creating a directory with mkdirs("top/interim/dir"))
> * When the leaf is moved out from the implicitly created directory making
> this directory an empty directory
> * Then a FileNotFoundException is thrown when getFileStatus or listStatus is
> called on the interim directory.
> The expected behaviour:
> after the directory is becoming empty, the directory should still be part of
> the file system, moreover an empty FileStatus array should be returned when
> listStatus is called on it, and also a valid FileStatus object should be
> returned when getFileStatus is called on it.
>
>
> As this issue is present with Hive, and as this is how a FileSystem is
> expected to work this seems to be an at least critical issue as I see, please
> feel free to change the priority if needed.
> Also please note that, if the interim directory is explicitly created with
> mkdirs("top/interim") before creating the leaf, then the issue does not
> appear.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
