[
https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=312505&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312505
]
ASF GitHub Bot logged work on HDDS-2119:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/19 05:20
Start Date: 14/Sep/19 05:20
Worklog Time Spent: 10m
Work Description: elek commented on issue #1435: HDDS-2119. Use
checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle
validation.
URL: https://github.com/apache/hadoop/pull/1435#issuecomment-531450551
Thanks @nandakumar131 the patch. Unfortunately it seems to be failing for me
with testing it with the checkstyle.sh.
Until now the checkstyle.sh did a `mvn checkstyle:check` without compilation
(which made it very fast). But now you should have the build-tools compiled and
installed to do a full checkstyle check.
I don't know what is the good solution here
1. We can use file references instead of artifact references to define the
checkstyle rule files
2. Or we can add the required build-tools install to the checkstyle.sh
I liked that it was very fast until know, therefore I would prefer the first
one, but there could be other options...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 312505)
Time Spent: 1h 50m (was: 1h 40m)
> Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle
> validation
> ----------------------------------------------------------------------------------------
>
> Key: HDDS-2119
> URL: https://issues.apache.org/jira/browse/HDDS-2119
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to
> use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for
> checkstyle validation.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
