[ 
https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931827#comment-16931827
 ] 

Íñigo Goiri commented on HDFS-14844:
------------------------------------

The failed unit tests seem unrelated and I think this works.
The only issue is the lack of test coverage.
Not sure what we can add easily to make sure the parameter kicks in.

A minor comment: we should fix the indentation (too many spaces) in 
BlockReaderRemote#401-402.

> Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream  
> configurable
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-14844
>                 URL: https://issues.apache.org/jira/browse/HDFS-14844
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Lisheng Sun
>            Assignee: Lisheng Sun
>            Priority: Minor
>         Attachments: HDFS-14844.001.patch, HDFS-14844.002.patch, 
> HDFS-14844.003.patch, HDFS-14844.004.patch
>
>
> details for HDFS-14820



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to