[ https://issues.apache.org/jira/browse/HDDS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933578#comment-16933578 ]
Hudson commented on HDDS-2110: ------------------------------ FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17335 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/17335/]) HDDS-2110. Arbitrary file can be downloaded with the help of (aengineer: rev f6d884cd118fdb6987eb3c369fc9a4c9317acf68) * (add) hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/server/TestProfileServlet.java * (edit) hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/ProfileServlet.java > Arbitrary file can be downloaded with the help of ProfilerServlet > ----------------------------------------------------------------- > > Key: HDDS-2110 > URL: https://issues.apache.org/jira/browse/HDDS-2110 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Native > Reporter: Aayush > Assignee: Elek, Marton > Priority: Major > Labels: pull-request-available > Fix For: 0.5.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > The LOC 324 in the file > [ProfileServlet.java|https://github.com/apache/hadoop/blob/217bdbd940a96986df3b96899b43caae2b5a9ed2/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/ProfileServlet.java] > is prone to an arbitrary file download:- > {code:java} > protected void doGetDownload(String fileName, final HttpServletRequest req, > final HttpServletResponse resp) throws IOException { > File requestedFile = > ProfileServlet.OUTPUT_DIR.resolve(fileName).toAbsolutePath().toFile();{code} > As the String fileName is directly considered as the requested file. > > Which is called at LOC 180 with HTTP request directly passed:- > {code:java} > if (req.getParameter("file") != null) { > doGetDownload(req.getParameter("file"), req, resp); > return; > } > {code} > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org