[ https://issues.apache.org/jira/browse/HDFS-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148632#comment-13148632 ]
Aaron T. Myers commented on HDFS-2547: -------------------------------------- +1, patch looks good to me. > ReplicationTargetChooser has incorrect block placement comments > --------------------------------------------------------------- > > Key: HDFS-2547 > URL: https://issues.apache.org/jira/browse/HDFS-2547 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 0.20.1 > Reporter: Harsh J > Assignee: Harsh J > Priority: Trivial > Fix For: 0.20.206.0 > > Attachments: HDFS-2547.patch, HDFS-2547.patch > > > {code} > /** The class is responsible for choosing the desired number of targets > * for placing block replicas. > * The replica placement strategy is that if the writer is on a datanode, > * the 1st replica is placed on the local machine, > * otherwise a random datanode. The 2nd replica is placed on a datanode > * that is on a different rack. The 3rd replica is placed on a datanode > * which is on the same rack as the **first replca**. > */ > {code} > That should read "second replica". The test cases confirm that this is the > behavior, as well as the docs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira