[ https://issues.apache.org/jira/browse/HDFS-14850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940182#comment-16940182 ]
Íñigo Goiri commented on HDFS-14850: ------------------------------------ Thanks [~leosun08] for the patch. Committed to trunk. > Optimize FileSystemAccessService#getFileSystemConfiguration > ----------------------------------------------------------- > > Key: HDFS-14850 > URL: https://issues.apache.org/jira/browse/HDFS-14850 > Project: Hadoop HDFS > Issue Type: Improvement > Components: httpfs, performance > Reporter: Lisheng Sun > Assignee: Lisheng Sun > Priority: Major > Fix For: 3.3.0 > > Attachments: HDFS-14850.001.patch, HDFS-14850.002.patch, > HDFS-14850.003.patch, HDFS-14850.004(2).patch, HDFS-14850.004.patch, > HDFS-14850.005.patch > > > {code:java} > @Override > public Configuration getFileSystemConfiguration() { > Configuration conf = new Configuration(true); > ConfigurationUtils.copy(serviceHadoopConf, conf); > conf.setBoolean(FILE_SYSTEM_SERVICE_CREATED, true); > // Force-clear server-side umask to make HttpFS match WebHDFS behavior > conf.set(FsPermission.UMASK_LABEL, "000"); > return conf; > } > {code} > As above code,when call > FileSystemAccessService#getFileSystemConfiguration,current code new > Configuration every time. > It is not necessary and affects performance. I think it only need to new > Configuration in FileSystemAccessService#init once and > FileSystemAccessService#getFileSystemConfiguration get it. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org