[
https://issues.apache.org/jira/browse/HDDS-2034?focusedWorklogId=320100&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320100
]
ASF GitHub Bot logged work on HDDS-2034:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/19 02:36
Start Date: 29/Sep/19 02:36
Worklog Time Spent: 10m
Work Description: ChenSammi commented on issue #1469: HDDS-2034. Async
RATIS pipeline creation and destroy through heartbea…
URL: https://github.com/apache/hadoop/pull/1469#issuecomment-536242054
> @ChenSammi Thanks a lot for working on this! Please find my comments below.
>
> 1. For the SafeModeRules, if we allow pipeline creation during safe
mode we need to modify the rules so that newly created pipelines are not
counted in the rule.
>
> 2. Can we just trigger PipelineReport from the datanodes after
creation of pipeline instead of CreatePipelineACK? That would greatly simplify
the OPEN pipeline code.
Thanks @lokeshj1703 for view the patch.
1. For SafeModeRules, I do modified the HealthyPipelineSafeModeRule a bit.
Add two properties, one is "hdds.scm.safemode.pipeline.creation" to control
whether create pipeline in safemode.
Another is "hdds.scm.safemode.min.pipeline" control the minimum pipeline
number to exit safe mode when create pipeline in safemode is enabled.
2. It's a good point. I will check the code to see if I leverage the
trigger pipelineReport to replace the CreatePipelineACK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 320100)
Time Spent: 8h 20m (was: 8h 10m)
> Async RATIS pipeline creation and destroy through heartbeat commands
> --------------------------------------------------------------------
>
> Key: HDDS-2034
> URL: https://issues.apache.org/jira/browse/HDDS-2034
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Sammi Chen
> Assignee: Sammi Chen
> Priority: Major
> Labels: pull-request-available
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> Currently, pipeline creation and destroy are synchronous operations. SCM
> directly connect to each datanode of the pipeline through gRPC channel to
> create the pipeline to destroy the pipeline.
> This task is to remove the gRPC channel, send pipeline creation and destroy
> action through heartbeat command to each datanode.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
