[
https://issues.apache.org/jira/browse/HDDS-2019?focusedWorklogId=320795&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320795
]
ASF GitHub Bot logged work on HDDS-2019:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/19 19:29
Start Date: 30/Sep/19 19:29
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1489: HDDS-2019.
Handle Set DtService of token in S3Gateway for OM HA.
URL: https://github.com/apache/hadoop/pull/1489#discussion_r329748308
##########
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneServiceProvider.java
##########
@@ -20,33 +20,75 @@
import org.apache.hadoop.hdds.conf.OzoneConfiguration;
import org.apache.hadoop.io.Text;
import org.apache.hadoop.ozone.OmUtils;
+import org.apache.hadoop.ozone.s3.util.OzoneS3Util;
import org.apache.hadoop.security.SecurityUtil;
import javax.annotation.PostConstruct;
import javax.enterprise.context.ApplicationScoped;
import javax.enterprise.inject.Produces;
import javax.inject.Inject;
+
+import java.util.Arrays;
+import java.util.Collection;
+
+import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_NODES_KEY;
+import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_SERVICE_IDS_KEY;
+
/**
* This class creates the OM service .
*/
@ApplicationScoped
public class OzoneServiceProvider {
- private Text omServiceAdd;
+ private Text omServiceAddr;
+
+ private String omserviceID;
@Inject
private OzoneConfiguration conf;
@PostConstruct
public void init() {
- omServiceAdd = SecurityUtil.buildTokenService(OmUtils.
- getOmAddressForClients(conf));
+ Collection<String> serviceIdList =
+ conf.getTrimmedStringCollection(OZONE_OM_SERVICE_IDS_KEY);
+ if (serviceIdList.size() == 0) {
+ // Non-HA cluster
+ omServiceAddr = SecurityUtil.buildTokenService(OmUtils.
+ getOmAddressForClients(conf));
+ } else {
+ // HA cluster.
+ //For now if multiple service id's are configured we throw exception.
Review comment:
This is very similar to what HDFS HA does. Since OM support service
discovery, can we get the internal service id via service discovery?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 320795)
Time Spent: 3h 20m (was: 3h 10m)
> Handle Set DtService of token in S3Gateway for OM HA
> ----------------------------------------------------
>
> Key: HDDS-2019
> URL: https://issues.apache.org/jira/browse/HDDS-2019
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> When OM HA is enabled, when tokens are generated, the service name should be
> set with address of all OM's.
>
> Current without HA, it is set with Om RpcAddress string. This Jira is to
> handle:
> # Set dtService with all OM address. Right now in OMClientProducer, UGI is
> created with S3 token, and serviceName of token is set with OMAddress, for HA
> case, this should be set with all OM RPC addresses.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
