[ 
https://issues.apache.org/jira/browse/HDDS-2216?focusedWorklogId=322616&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322616
 ]

ASF GitHub Bot logged work on HDDS-2216:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Oct/19 13:48
            Start Date: 03/Oct/19 13:48
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on issue #1570: HDDS-2216. 
Rename HADOOP_RUNNER_VERSION to OZONE_RUNNER_VERSION in co…
URL: https://github.com/apache/hadoop/pull/1570#issuecomment-537953697
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 295 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | 0 | shelldocs | 1 | Shelldocs was not available. |
   | 0 | yamllint | 0 | yamllint was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 32 | Maven dependency ordering for branch |
   | -1 | mvninstall | 34 | hadoop-hdds in trunk failed. |
   | -1 | mvninstall | 35 | hadoop-ozone in trunk failed. |
   | -1 | compile | 20 | hadoop-hdds in trunk failed. |
   | -1 | compile | 15 | hadoop-ozone in trunk failed. |
   | +1 | mvnsite | 0 | trunk passed |
   | -1 | pylint | 1 | Error running pylint. Please check pylint stderr files. |
   | +1 | shadedclient | 886 | branch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 22 | hadoop-hdds in trunk failed. |
   | -1 | javadoc | 18 | hadoop-ozone in trunk failed. |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 17 | Maven dependency ordering for patch |
   | -1 | mvninstall | 34 | hadoop-hdds in the patch failed. |
   | -1 | mvninstall | 37 | hadoop-ozone in the patch failed. |
   | -1 | compile | 24 | hadoop-hdds in the patch failed. |
   | -1 | compile | 18 | hadoop-ozone in the patch failed. |
   | -1 | javac | 24 | hadoop-hdds in the patch failed. |
   | -1 | javac | 18 | hadoop-ozone in the patch failed. |
   | +1 | mvnsite | 0 | the patch passed |
   | -1 | pylint | 2 | Error running pylint. Please check pylint stderr files. |
   | +1 | pylint | 2 | There were no new pylint issues. |
   | +1 | shellcheck | 2 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 787 | patch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 21 | hadoop-hdds in the patch failed. |
   | -1 | javadoc | 18 | hadoop-ozone in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 27 | hadoop-hdds in the patch failed. |
   | -1 | unit | 24 | hadoop-ozone in the patch failed. |
   | +1 | asflicense | 31 | The patch does not generate ASF License warnings. |
   | | | 2568 | |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1570 |
   | Optional Tests | dupname asflicense mvnsite unit shellcheck shelldocs 
compile javac javadoc mvninstall shadedclient yamllint pylint |
   | uname | Linux fb3f6f5a092c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / c19fa3d |
   | Default Java | 1.8.0_222 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/branch-mvninstall-hadoop-hdds.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/branch-mvninstall-hadoop-ozone.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/branch-compile-hadoop-hdds.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/branch-compile-hadoop-ozone.txt
 |
   | pylint | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/branch-pylint-stderr.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/branch-javadoc-hadoop-hdds.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/branch-javadoc-hadoop-ozone.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/patch-mvninstall-hadoop-hdds.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/patch-mvninstall-hadoop-ozone.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/patch-compile-hadoop-hdds.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/patch-compile-hadoop-ozone.txt
 |
   | javac | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/patch-compile-hadoop-hdds.txt
 |
   | javac | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/patch-compile-hadoop-ozone.txt
 |
   | pylint | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/patch-pylint-stderr.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/patch-javadoc-hadoop-hdds.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/patch-javadoc-hadoop-ozone.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/patch-unit-hadoop-hdds.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/artifact/out/patch-unit-hadoop-ozone.txt
 |
   |  Test Results | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/testReport/ |
   | Max. process+thread count | 340 (vs. ulimit of 5500) |
   | modules | C: hadoop-ozone hadoop-ozone/fault-injection-test/network-tests 
hadoop-ozone/dist U: hadoop-ozone |
   | Console output | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1570/2/console |
   | versions | git=2.7.4 maven=3.3.9 shellcheck=0.4.6 pylint=1.9.2 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 322616)
    Time Spent: 1.5h  (was: 1h 20m)

> Rename HADOOP_RUNNER_VERSION to OZONE_RUNNER_VERSION in compose .env files
> --------------------------------------------------------------------------
>
>                 Key: HDDS-2216
>                 URL: https://issues.apache.org/jira/browse/HDDS-2216
>             Project: Hadoop Distributed Data Store
>          Issue Type: Task
>          Components: docker
>            Reporter: Marton Elek
>            Assignee: YiSheng Lien
>            Priority: Major
>              Labels: newbie, pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> In HDDS-1698 we replaced our apache/hadoop-runner base image to 
> apache/ozone-runner base image. 
> The version of the image is set by the .env files under the 
> hadoop-ozone/dist/src/main/compose directories
> {code:java}
> cd hadoop-ozone/dist/src/main/compose
> grep -r HADOOP_RUNNER .
> ./ozoneperf/docker-compose.yaml:      image: 
> apache/ozone-runner:${HADOOP_RUNNER_VERSION}
> ./ozoneperf/docker-compose.yaml:      image: 
> apache/ozone-runner:${HADOOP_RUNNER_VERSION}
> ./ozoneperf/docker-compose.yaml:      image: 
> apache/ozone-runner:${HADOOP_RUNNER_VERSION}
>  {code}
> But the name of the variable is HADOOP_RUNNER_VERSION instead of 
> OZONE_RUNNER_VERSION.
> Would be great to rename it the OZONE_RUNNER_VERSION.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to