[
https://issues.apache.org/jira/browse/HDDS-2071?focusedWorklogId=322885&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322885
]
ASF GitHub Bot logged work on HDDS-2071:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Oct/19 19:43
Start Date: 03/Oct/19 19:43
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1583: HDDS-2071.
Support filters in ozone insight point
URL: https://github.com/apache/hadoop/pull/1583#discussion_r331205328
##########
File path:
hadoop-ozone/insight/src/main/java/org/apache/hadoop/ozone/insight/LogSubcommand.java
##########
@@ -59,6 +61,10 @@
+ "show more information / detailed message")
private boolean verbose;
+ @CommandLine.Option(names = "-f", description = "Enable verbose mode to "
+ + "show more information / detailed message")
Review comment:
Description should be updated (is copied from `-v`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 322885)
Time Spent: 40m (was: 0.5h)
> Support filters in ozone insight point
> --------------------------------------
>
> Key: HDDS-2071
> URL: https://issues.apache.org/jira/browse/HDDS-2071
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Marton Elek
> Assignee: Marton Elek
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> With Ozone insight we can print out all the logs / metrics of one specific
> component s (eg. scm.node-manager or scm.node-manager).
> It would be great to support additional filtering capabilities where the
> output is filtered based on specific keys.
> For example to print out all of the logs related to one datanode or related
> to one type of RPC request.
> Filter should be a key value map (eg. --filter
> datanode=sjdhfhf,rpc=createChunk) which can be defined in the ozone insight
> CLI.
> As we have no option to add additional tags to the logs (it may be supported
> by log4j2 but not with slf4k), the first implementation can be implemented by
> pattern matching.
> For example in SCMNodeManager.processNodeReport contains trace/debug logs
> which includes the " [datanode={}]" part. This formatting convention can be
> used to print out the only the related information.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
