[ 
https://issues.apache.org/jira/browse/HDDS-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944673#comment-16944673
 ] 

Hudson commented on HDDS-2237:
------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17478 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/17478/])
HDDS-2237. KeyDeletingService throws NPE if it's started too early (bharat: rev 
3f166512afa2564ba1f34512e31476282af862be)
* (edit) 
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestKeyDeletingService.java
* (edit) 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java


> KeyDeletingService throws NPE if it's started too early
> -------------------------------------------------------
>
>                 Key: HDDS-2237
>                 URL: https://issues.apache.org/jira/browse/HDDS-2237
>             Project: Hadoop Distributed Data Store
>          Issue Type: Task
>          Components: om
>            Reporter: Marton Elek
>            Assignee: Marton Elek
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> 1. OzoneManager starts KeyManager
> 2. KeyManager starts KeyDeletingService
> 3. KeyDeletingService uses OzoneManager.isLeader()
> 4. OzoneManager.isLeader() uses omRatisServer
> 5. omRatisServer can be null (bumm)
>  
> Now the initialization order in OzoneManager:
>  
> new KeymanagerServer() *Includes start()!!!!*
> omRatisServer initialization
> start() (includes KeyManager.start())
>  
> The solution seems to be easy: start the key manager only from the 
> OzoneManager.start() and not from the OzoneManager.instantiateServices()



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to