[ 
https://issues.apache.org/jira/browse/HDDS-2233?focusedWorklogId=323637&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323637
 ]

ASF GitHub Bot logged work on HDDS-2233:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Oct/19 18:09
            Start Date: 04/Oct/19 18:09
    Worklog Time Spent: 10m 
      Work Description: fapifta commented on issue #1596: HDDS-2233 - Remove 
ByteStringHelper and refactor the code to the place where it used
URL: https://github.com/apache/hadoop/pull/1596#issuecomment-538504664
 
 
   Acceptance test failures seems to be related to an internally examined 
similar failure in XCeiverClientGrpc, where the relevant stack trace is:
   Caused by: java.lang.NullPointerException
       at 
org.apache.hadoop.hdds.scm.XceiverClientGrpc.sendCommandAsync(XceiverClientGrpc.java:387)
       at 
org.apache.hadoop.hdds.scm.XceiverClientGrpc.sendCommandWithRetry(XceiverClientGrpc.java:285)
       at 
org.apache.hadoop.hdds.scm.XceiverClientGrpc.sendCommandWithTraceIDAndRetry(XceiverClientGrpc.java:251)
       at 
org.apache.hadoop.hdds.scm.XceiverClientGrpc.sendCommand(XceiverClientGrpc.java:234)
       at 
org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls.readChunk(ContainerProtocolCalls.java:245)
       at 
org.apache.hadoop.hdds.scm.storage.ChunkInputStream.readChunk(ChunkInputStream.java:335)
       at 
org.apache.hadoop.hdds.scm.storage.ChunkInputStream.readChunkFromContainer(ChunkInputStream.java:307)
       at 
org.apache.hadoop.hdds.scm.storage.ChunkInputStream.prepareRead(ChunkInputStream.java:249)
       at 
org.apache.hadoop.hdds.scm.storage.ChunkInputStream.read(ChunkInputStream.java:144)
       at 
org.apache.hadoop.hdds.scm.storage.BlockInputStream.read(BlockInputStream.java:239)
       at 
org.apache.hadoop.ozone.client.io.KeyInputStream.read(KeyInputStream.java:171)
       at 
org.apache.hadoop.fs.ozone.OzoneFSInputStream.read(OzoneFSInputStream.java:52)
       at org.apache.hadoop.fs.FSInputStream.read(FSInputStream.java:75)
       at org.apache.hadoop.fs.FSInputStream.readFully(FSInputStream.java:121)
       at 
org.apache.hadoop.fs.FSDataInputStream.readFully(FSDataInputStream.java:112)
       at org.apache.orc.impl.ReaderImpl.extractFileTail(ReaderImpl.java:555)
   
   From the Integration test failures 
org.apache.hadoop.ozone.client.rpc.TestFailureHandlingByClient failure might be 
related, but there in the output before the error we can see that the client 
wanted replication factor of 3, while the cluster had only 1 DN. 
   
   So issues seem to be unrelated, however I can not run these tests locally as 
easy as they are timing out in my local machine.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 323637)
    Time Spent: 40m  (was: 0.5h)

> Remove ByteStringHelper and refactor the code to the place where it used
> ------------------------------------------------------------------------
>
>                 Key: HDDS-2233
>                 URL: https://issues.apache.org/jira/browse/HDDS-2233
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Istvan Fajth
>            Priority: Critical
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> See HDDS-2203 where there is a race condition reported by me.
> Later in the discussion we agreed that it is better to refactor the code and 
> remove the class completely for now, and that would also resolve the race 
> condition.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to