[ https://issues.apache.org/jira/browse/HDFS-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152611#comment-13152611 ]
Hadoop QA commented on HDFS-2562: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12504155/hdfs-2562.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1567//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1567//console This message is automatically generated. > Refactor DN configuration variables out of DataNode class > --------------------------------------------------------- > > Key: HDFS-2562 > URL: https://issues.apache.org/jira/browse/HDFS-2562 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node > Affects Versions: 0.24.0, 0.23.1 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Minor > Attachments: hdfs-2562.txt > > > Right now there are many member variables in DataNode.java which are just > read from configuration when the DN is started. Similar to what we did with > DFSClient, we should refactor them into a new DNConf class which can be > passed around - the motivation is to remove the many references we have > throughout the code that read package-protected members of DataNode and > reduce the number of members in DataNode itself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira