[
https://issues.apache.org/jira/browse/HDDS-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946015#comment-16946015
]
Anu Engineer commented on HDDS-2261:
------------------------------------
Thank you for finding this issue. Appreciate it.
> Change readChunk methods to return ByteBuffer
> ---------------------------------------------
>
> Key: HDDS-2261
> URL: https://issues.apache.org/jira/browse/HDDS-2261
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Istvan Fajth
> Priority: Major
> Labels: pull-request-available
>
> During refactoring to HDDS-2233 I realized the following:
> KeyValueHandler.handleReadChunk and handleGetSmallFile methods are using
> ChunkManager.readChunk, which returns a byte[], but then both of them (the
> only usage points) converts the returning byte[] to a ByteBuffer, and then to
> a ByteString.
> ChunkManagerImpl on the other hand in readChunk utilizes
> ChunkUtils.readChunk, which in order to conform the return value converts a
> ByteBuffer back to a byte[].
> I open this JIRA to change the internal logic to fully rely on ByteBuffers
> instead of converting from ByteBuffer to byte[] then to ByteBuffer again.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
