[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947056#comment-16947056
]
Íñigo Goiri commented on HDFS-14891:
------------------------------------
I'm not sure if we need to qualify scheme to make it webScheme or similar.
Technically, the scheme is a little ambiguous as we could have, hdfs, webhdfs,
swebhdfs, http, etc.
The other thing is that we are tuning most methods adding the scheme at the end.
Does it make sense to make it right next to the webAddress setting?
For example:
{code}
public static MembershipState newInstance(String router, String nameservice,
String namenode, String clusterId, String blockPoolId, String rpcAddress,
String serviceAddress, String lifelineAddress,
String webScheme, String webAddress,
FederationNamenodeServiceState state, boolean safemode) {
{code}
Unfortunately, we cannot do this in the protobuf definition but at least this
is something.
We also need to update the javadocs.
> RBF: namenode links in NameFederation Health page (federationhealth.html)
> cannot use https scheme
> --------------------------------------------------------------------------------------------------
>
> Key: HDFS-14891
> URL: https://issues.apache.org/jira/browse/HDFS-14891
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf, ui
> Reporter: Xieming Li
> Assignee: Xieming Li
> Priority: Major
> Attachments: HDFS-14891.001.patch, HDFS-14891.patch
>
>
> The scheme of links in federationhealth.html are hard coded as 'http'.
> It should be set to 'https' when dfs.http.policy is HTTPS_ONLY
> (HTTP_AND_HTTPS also, maybe)
>
> [https://github.com/apache/hadoop/blob/c99a12167ff9566012ef32104a3964887d62c899/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/webapps/router/federationhealth.html#L168-L169]
> [https://github.com/apache/hadoop/blob/c99a12167ff9566012ef32104a3964887d62c899/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/webapps/router/federationhealth.html#L236]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
