[ https://issues.apache.org/jira/browse/HDDS-1737?focusedWorklogId=326178&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-326178 ]
ASF GitHub Bot logged work on HDDS-1737: ---------------------------------------- Author: ASF GitHub Bot Created on: 10/Oct/19 08:33 Start Date: 10/Oct/19 08:33 Worklog Time Spent: 10m Work Description: cxorm commented on pull request #1559: HDDS-1737. Add Volume check in KeyManager and File Operations. URL: https://github.com/apache/hadoop/pull/1559#discussion_r333392433 ########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMDirectoryCreateRequest.java ########## @@ -139,12 +140,15 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, acquiredLock = omMetadataManager.getLock().acquireLock(BUCKET_LOCK, volumeName, bucketName); - // TODO: Not checking volume exist here, once we have full cache we can - // add volume exist check also. + // Check volume exist. + String volumeKey = omMetadataManager.getVolumeKey(volumeName); + if (!omMetadataManager.getVolumeTable().isExist(volumeKey)) { + throw new OMException("Volume not found " + volumeName, Review comment: Thanks @bharatviswa504 I found the check also can be done by the base class method, so I fix it and add some tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 326178) Time Spent: 3.5h (was: 3h 20m) > Add Volume check in KeyManager and File Operations > -------------------------------------------------- > > Key: HDDS-1737 > URL: https://issues.apache.org/jira/browse/HDDS-1737 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Bharat Viswanadham > Assignee: YiSheng Lien > Priority: Major > Labels: newbie, pull-request-available > Time Spent: 3.5h > Remaining Estimate: 0h > > This is to address a TODO to check volume checks when performing Key/File > operations. > > // TODO: Not checking volume exist here, once we have full cache we can > // add volume exist check also. > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org