[
https://issues.apache.org/jira/browse/HDFS-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153290#comment-13153290
]
Eli Collins commented on HDFS-2563:
-----------------------------------
+1 lgtm
Nit: lines 846 and 1267 can fold onto the previous line
> Some cleanup in BPOfferService
> ------------------------------
>
> Key: HDFS-2563
> URL: https://issues.apache.org/jira/browse/HDFS-2563
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-2563.txt, hdfs-2563.txt
>
>
> BPOfferService is currently rather difficult to follow and not really
> commented. This JIRA is to clean up the code a bit, add javadocs/comments
> where necessary, and improve the formatting of the log messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
