[ https://issues.apache.org/jira/browse/HDDS-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953929#comment-16953929 ]
Attila Doroszlai commented on HDDS-2318: ---------------------------------------- Using a supplier with the right {{toString()}} method might help: https://github.com/apache/incubator-ratis/blob/master/ratis-common/src/main/java/org/apache/ratis/util/StringUtils.java#L130-L137 > Avoid proto::tostring in preconditions to save CPU cycles > --------------------------------------------------------- > > Key: HDDS-2318 > URL: https://issues.apache.org/jira/browse/HDDS-2318 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Manager > Reporter: Rajesh Balamohan > Assignee: Bharat Viswanadham > Priority: Major > Labels: performance > Attachments: Screenshot 2019-10-17 at 6.10.22 PM.png > > > [https://github.com/apache/hadoop-ozone/blob/61f4aa30f502b34fd778d9b37b1168721abafb2f/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java#L117] > > This ends up converting proto toString in precondition checks and burns CPU > cycles. {{request.toString()}} can be added in debug log on need basis. > > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org