[
https://issues.apache.org/jira/browse/HDDS-2349?focusedWorklogId=332493&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-332493
]
ASF GitHub Bot logged work on HDDS-2349:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/19 08:26
Start Date: 23/Oct/19 08:26
Worklog Time Spent: 10m
Work Description: sodonnel commented on pull request #75: HDDS-2349
QueryNode does not respect null values for opState or state
URL: https://github.com/apache/hadoop-ozone/pull/75
In HDDS-2197, the queryNode API call was changed to allow operational state
(in_service, decommissioning etc) to be passed along with the node health
state. This changed allowed for a null state to indicate a wildcard, so passing:
opState = null
healthState = HEALTHY
Allows one to find all the healthy nodes, irrespective of their opState.
However, for an enum protobuf field, if no value is specified, the first
enum in the set is returned as the default. This means that when a null is
passed for opState, only the IN_SERVICE nodes are returned. Similar for health
state - passing a null will return only HEALTHY nodes.
This PR will fix this issue so the null value acts as a wildcard as intended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 332493)
Remaining Estimate: 0h
Time Spent: 10m
> QueryNode does not respect null values for opState or state
> -----------------------------------------------------------
>
> Key: HDDS-2349
> URL: https://issues.apache.org/jira/browse/HDDS-2349
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: SCM
> Affects Versions: 0.5.0
> Reporter: Stephen O'Donnell
> Assignee: Stephen O'Donnell
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In HDDS-2197, the queryNode API call was changed to allow operational state
> (in_service, decommissioning etc) to be passed along with the node health
> state. This changed allowed for a null state to indicate a wildcard, so
> passing:
> opState = null
> healthState = HEALTHY
> Allows one to find all the healthy nodes, irrespective of their opState.
> However, for an enum protobuf field, if no value is specified, the first enum
> in the set is returned as the default. This means that when a null is passed
> for opState, only the IN_SERVICE nodes are returned. Similar for health state
> - passing a null will return only HEALTHY nodes.
> This PR will fix this issue so the null value acts as a wildcard as intended.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
