[ https://issues.apache.org/jira/browse/HDFS-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958434#comment-16958434 ]
Fei Hui commented on HDFS-14923: -------------------------------- [~ayushtkn] [~weichiu] Could you please take look? Thanks > Remove dead code from HealthMonitor > ----------------------------------- > > Key: HDFS-14923 > URL: https://issues.apache.org/jira/browse/HDFS-14923 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 3.3.0, 3.2.1, 3.1.3 > Reporter: Fei Hui > Assignee: Fei Hui > Priority: Minor > Attachments: HDFS-14923.001.patch > > > Dig ZKFC source code and find that the dead code as follow > {code} > public void removeCallback(Callback cb) { > callbacks.remove(cb); > } > public synchronized void removeServiceStateCallback(ServiceStateCallback cb) { > serviceStateCallbacks.remove(cb); > } > synchronized HAServiceStatus getLastServiceStatus() { > return lastServiceState; > } > {code} > It's useless, and should be deleted. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org