[
https://issues.apache.org/jira/browse/HDFS-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961004#comment-16961004
]
Steve Loughran commented on HDFS-8631:
--------------------------------------
Hi, just noticed this.
Can can I remind people that I that I generally expect any changes made to file
system APIs to be accompanied by changes to filesystem.md so as to define,
strictly, what it's meant to do. Pulling up what HDFS does and saying "that"
doesn't count, because it doesn't always cover the corner cases, or clearly
define what happens.
In particular, I don't see any tests in this patch which explore what happens
if I set negative quotas, invoke the operation on paths which do not exist,
etc. etc. These are critical to verify that new implementations of any FS API
do actually behave the way HDFS does. People who provide their own
implementations of the APIs depend on this -and people who use the APIs deserve
the actual details of what happens, because "trace through what HDFS does"
doesn't count as documentation.
# mention to me when you're going near this class as I can make suggestions in
advance.
# I now expect the documentation and the extra testing. Who is going to
volunteer to do this?
> WebHDFS : Support setQuota
> --------------------------
>
> Key: HDFS-8631
> URL: https://issues.apache.org/jira/browse/HDFS-8631
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 2.7.2
> Reporter: nijel
> Assignee: Chao Sun
> Priority: Major
> Fix For: 3.3.0
>
> Attachments: HDFS-8631-001.patch, HDFS-8631-002.patch,
> HDFS-8631-003.patch, HDFS-8631-004.patch, HDFS-8631-005.patch,
> HDFS-8631-006.patch, HDFS-8631-007.patch, HDFS-8631-008.patch,
> HDFS-8631-009.patch, HDFS-8631-010.patch, HDFS-8631-011.patch
>
>
> User is able do quota management from filesystem object. Same operation can
> be allowed trough REST API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
