[
https://issues.apache.org/jira/browse/HDFS-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961096#comment-16961096
]
Xiaoqiao He commented on HDFS-13736:
------------------------------------
[^HDFS-13736.006.patch] LGTM, check the failed unit tests, it is unrelated with
this changes I think.
It will be better if we keep the following code format same with community
style.
1. keep 4 spaces when start with newlines.
{code:java}
+ targets = chooseTarget(2, dataNodes[3], null,
+ favouredNodes);
+ assertEquals(targets.length, 2);
+ for (int i = 0; i < targets.length; i++) {
+ assertTrue("Target should be a part of Expected Targets",
+ expectedTargets.contains(targets[i].getDatanodeDescriptor()));
{code}
2. annotation start with upper case letter at most times.
{code:java}
* choose storage of local or favored node.
* @param localOrFavoredNode local or favored node
* @param isFavoredNode if target node is favored node
{code}
non-essentials but nice to have. Thanks [~xiaodong.hu].
> BlockPlacementPolicyDefault can not choose favored nodes when
> 'dfs.namenode.block-placement-policy.default.prefer-local-node' set to false
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-13736
> URL: https://issues.apache.org/jira/browse/HDFS-13736
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: hu xiaodong
> Assignee: hu xiaodong
> Priority: Major
> Attachments: HDFS-13736.001.patch, HDFS-13736.002.patch,
> HDFS-13736.003.patch, HDFS-13736.004.patch, HDFS-13736.005.patch,
> HDFS-13736.006.patch
>
>
> BlockPlacementPolicyDefault can not choose favored nodes when
> 'dfs.namenode.block-placement-policy.default.prefer-local-node' set to false.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
