[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962758#comment-16962758
]
Xiaoqiao He commented on HDFS-14882:
------------------------------------
Thanks [~pifta] for your suggestions,
{quote}I would suggest two more things to do, we might deprecate the old sorter
methods, as we most likely won't need them on the long run, as their use
effectively overrides the new setting, and an update would be nice to the
APIDoc of these methods.{quote}
It make sense for me. I agree that the following methods should be removed.
BTW, this common interface is invoke by different classes. I would like to
update that later.
{code:java}
public void sortByDistance(Node reader, Node[] nodes, int activeLen)
public void sortByDistanceUsingNetworkLocation(Node reader, Node[] nodes,
int activeLen)
{code}
cc [~ayushtkn],[~elgoiri] any other comments?
> Consider DataNode load when #getBlockLocation
> ---------------------------------------------
>
> Key: HDFS-14882
> URL: https://issues.apache.org/jira/browse/HDFS-14882
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Xiaoqiao He
> Assignee: Xiaoqiao He
> Priority: Major
> Attachments: HDFS-14882.001.patch, HDFS-14882.002.patch,
> HDFS-14882.003.patch, HDFS-14882.004.patch, HDFS-14882.005.patch,
> HDFS-14882.006.patch, HDFS-14882.007.patch, HDFS-14882.008.patch,
> HDFS-14882.009.patch, HDFS-14882.suggestion
>
>
> Currently, we consider load of datanode when #chooseTarget for writer,
> however not consider it for reader. Thus, the process slot of datanode could
> be occupied by #BlockSender for reader, and disk/network will be busy
> workload, then meet some slow node exception. IIRC same case is reported
> times. Based on the fact, I propose to consider load for reader same as it
> did #chooseTarget for writer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
