[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963646#comment-16963646
]
Ayush Saxena commented on HDFS-14927:
-------------------------------------
Thanx [~LeonG] for the patch.
Had a quick look, Just a doubt :
{code:java}
425 future.get();
426 exec.shutdown();
{code}
This isn't in finally, if the test fails. after executor creation then these
lines won't be executed. Just give a check once.
Other than this, v007 LGTM
> RBF: Add metrics for async callers thread pool
> ----------------------------------------------
>
> Key: HDFS-14927
> URL: https://issues.apache.org/jira/browse/HDFS-14927
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Reporter: Leon Gao
> Assignee: Leon Gao
> Priority: Minor
> Attachments: HDFS-14927.001.patch, HDFS-14927.002.patch,
> HDFS-14927.003.patch, HDFS-14927.004.patch, HDFS-14927.005.patch,
> HDFS-14927.006.patch, HDFS-14927.007.patch
>
>
> It is good to add some monitoring on the async caller thread pool to handle
> fan-out RPC client requests, so we know the utilization and when to bump up
> dfs.federation.router.client.thread-size
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
