[ https://issues.apache.org/jira/browse/HDFS-14958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968875#comment-16968875 ]
Ayush Saxena commented on HDFS-14958: ------------------------------------- Thanx [~Jim_Brennan] for confirming, well it is very strange actually that the whole test class was not correct. Anyway, v001 LGTM +1 > TestBalancerWithNodeGroup is not using NetworkTopologyWithNodeGroup > ------------------------------------------------------------------- > > Key: HDFS-14958 > URL: https://issues.apache.org/jira/browse/HDFS-14958 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs > Affects Versions: 3.1.3 > Reporter: Jim Brennan > Assignee: Jim Brennan > Priority: Minor > Attachments: HDFS-14958.001.patch > > > TestBalancerWithNodeGroup is intended to test with > {{NetworkTopologyWithNodeGroup}}, but it is not configured correctly. > Because {{DFSConfigKeys.DFS_USE_DFS_NETWORK_TOPOLOGY_KEY}} defaults to true, > {{CommonConfigurationKeysPublic.NET_TOPOLOGY_IMPL_KEY}} is ignored and the > test actually uses the default {{DFSNetworkTopology}}. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org