[
https://issues.apache.org/jira/browse/HDDS-2415?focusedWorklogId=340042&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340042
]
ASF GitHub Bot logged work on HDDS-2415:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/19 17:20
Start Date: 07/Nov/19 17:20
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #128: HDDS-2415.
Completely disable tracer if hdds.tracing.enabled=false
URL: https://github.com/apache/hadoop-ozone/pull/128
## What changes were proposed in this pull request?
Skip registering a real tracer with `GlobalTracer` if `hdds.tracing.enabled`
is set to `false`. This lets us avoid tracer-related busywork.
https://issues.apache.org/jira/browse/HDDS-2415
## How was this patch tested?
1. Checked Jaeger in `ozoneperf` cluster with default config, verified that
it shows traces (OM, SCM, DN, Freon, S3 shell, Ozone shell)
2. With `OZONE-SITE.XML_hdds.tracing.enabled=false` added to
`docker-config`, verified that Jaeger shows no traces
3. Also with tracing disabled in `ozone` cluster, verified that
`GlobalTracer` no longer shows up in breakdown of allocations from
`HddsDispatcher.dispatch` in the profiler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 340042)
Remaining Estimate: 0h
Time Spent: 10m
> Completely disable tracer if hdds.tracing.enabled=false
> -------------------------------------------------------
>
> Key: HDDS-2415
> URL: https://issues.apache.org/jira/browse/HDDS-2415
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Minor
> Labels: perfomance, pull-request-available
> Attachments: allocations.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There is a config setting to enable/disable OpenTracing-based distributed
> tracing in Ozone ({{hdds.tracing.enabled}}). However, setting it to false
> does not prevent tracer initialization, which causes unnecessary object
> allocations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
