[
https://issues.apache.org/jira/browse/HDDS-2451?focusedWorklogId=340737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340737
]
ASF GitHub Bot logged work on HDDS-2451:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/19 20:38
Start Date: 08/Nov/19 20:38
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #135: HDDS-2451.
Use lazy string evaluation in preconditions
URL: https://github.com/apache/hadoop-ozone/pull/135
## What changes were proposed in this pull request?
Use the version of `Preconditions.check...` that accepts
`errorMessageTemplate` and `errorMessageArgs`.
There are occurrences of the `errorMessage` version left, but they do not
seem to be important:
1. use constant message, or
2. are infrequently used (eg. one-time init in `MetadataKeyFilters`), or
3. only append a plain `long` (container ID) to the message.
https://issues.apache.org/jira/browse/HDDS-2451
## How was this patch tested?
Ran related unit tests and checkstyle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 340737)
Remaining Estimate: 0h
Time Spent: 10m
> Use lazy string evaluation in preconditions
> -------------------------------------------
>
> Key: HDDS-2451
> URL: https://issues.apache.org/jira/browse/HDDS-2451
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Major
> Labels: performance, pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Avoid eagerly evaluating error messages of preconditions (similarly to
> HDDS-2318, but there may be other occurrences of the same issue).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
