[
https://issues.apache.org/jira/browse/HDDS-2458?focusedWorklogId=341188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341188
]
ASF GitHub Bot logged work on HDDS-2458:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/19 07:59
Start Date: 11/Nov/19 07:59
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #141: HDDS-2458.
Avoid list copy in ChecksumData
URL: https://github.com/apache/hadoop-ozone/pull/141
## What changes were proposed in this pull request?
Create `ChecksumData` with checksum list, instead of updating it right after
creation, to avoid unnecessarily copying the list.
https://issues.apache.org/jira/browse/HDDS-2458
## How was this patch tested?
Tested on 3-node cluster with a 120MB key. `ozone sh key get` verifies the
checksum.
```
ozone freon ockg -p test -t 1 -n 1 # easy volume and bucket creation ;)
cat share/ozone/lib/*jar > tmp.jar
ozone sh key put vol1/bucket1/test/large tmp.jar
ozone sh key get vol1/bucket1/test/large tmp.jar.out
diff -q tmp.jar tmp.jar.out
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 341188)
Remaining Estimate: 0h
Time Spent: 10m
> Avoid list copy in ChecksumData
> -------------------------------
>
> Key: HDDS-2458
> URL: https://issues.apache.org/jira/browse/HDDS-2458
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{ChecksumData}} is initially created with empty list of checksums, then it
> is updated with computed checksums, copying the list. The computed list can
> be set directly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
