[ https://issues.apache.org/jira/browse/HDDS-2463?focusedWorklogId=342180&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342180 ]
ASF GitHub Bot logged work on HDDS-2463: ---------------------------------------- Author: ASF GitHub Bot Created on: 12/Nov/19 21:32 Start Date: 12/Nov/19 21:32 Worklog Time Spent: 10m Work Description: xiaoyuyao commented on pull request #146: HDDS-2463. Reduce unnecessary getServiceInfo calls. Contributed by Xi… URL: https://github.com/apache/hadoop-ozone/pull/146 …aoyu Yao. ## What changes were proposed in this pull request? reduce unncessary getServiceInfo calls. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-2463 ## How was this patch tested? Run Ozone RPC related unit tests and acceptance tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 342180) Remaining Estimate: 0h Time Spent: 10m > Reduce unnecessary getServiceInfo calls > --------------------------------------- > > Key: HDDS-2463 > URL: https://issues.apache.org/jira/browse/HDDS-2463 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Affects Versions: 0.4.1 > Reporter: Xiaoyu Yao > Assignee: Xiaoyu Yao > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > OzoneManagerProtocolClientSideTranslatorPB.java Line 766-772 has multiple > impl.getServiceInfo() which can be reduced by adding a local variable. > {code:java} > > resp.addAllServiceInfo(impl.getServiceInfo().getServiceInfoList().stream() > .map(ServiceInfo::getProtobuf) > .collect(Collectors.toList())); > if (impl.getServiceInfo().getCaCertificate() != null) { > resp.setCaCertificate(impl.getServiceInfo().getCaCertificate()); {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org