[ https://issues.apache.org/jira/browse/HDDS-2105?focusedWorklogId=342234&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342234 ]
ASF GitHub Bot logged work on HDDS-2105: ---------------------------------------- Author: ASF GitHub Bot Created on: 12/Nov/19 22:14 Start Date: 12/Nov/19 22:14 Worklog Time Spent: 10m Work Description: smengcl commented on pull request #148: HDDS-2105. Merge OzoneClientFactory#getRpcClient functions URL: https://github.com/apache/hadoop-ozone/pull/148 ## What changes were proposed in this pull request? There are in total 6 overloaded `OzoneClientFactory#getRpcClient` functions now. Some of them are not used or just used once. Remove/merge some of them. (Should be fine to simply remove public function without deprecating at this moment since ozone is still in alpha?) ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-2105 ## How was this patch tested? Rerun all existing tests, since this is just a straightforward refactoring. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 342234) Remaining Estimate: 0h Time Spent: 10m > Merge OzoneClientFactory#getRpcClient functions > ----------------------------------------------- > > Key: HDDS-2105 > URL: https://issues.apache.org/jira/browse/HDDS-2105 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Siyao Meng > Assignee: Siyao Meng > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Ref: https://github.com/apache/hadoop/pull/1360#discussion_r321585214 > There will be 5 overloaded OzoneClientFactory#getRpcClient functions (when > HDDS-2007 is committed). They contains some redundant logic and unnecessarily > increases code paths. > Goal: Merge those functions into fewer. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org