[
https://issues.apache.org/jira/browse/HDDS-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976850#comment-16976850
]
Bharat Viswanadham edited comment on HDDS-2535 at 11/18/19 8:25 PM:
--------------------------------------------------------------------
Hi [~elek]
{quote}Independent from the flakiness I think a test where the timeout is 8
minutes and starts 1000 threads to insert 500 buckets (500_000 buckets all
together) it's more like an integration test and would be better to move the
slowest part to the integration-test project.
{quote}
I think now it should run quickly with the fix, and also I think it will not
take that much of time. On my local laptop, I see, it is always completed in
30sec.
And on github run I see it is completed in 53 seconds. I just want to keep this
test in UT, as this will detect any failure in the DoubleBuffer issue which is
a critical component in OM. (Why I want in UT, because we are going to force
sooner, UT should be always green)
{code:java}
1164[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
53.536 s - in
org.apache.hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse{code}
was (Author: bharatviswa):
Hi [~elek]
{quote}Independent from the flakiness I think a test where the timeout is 8
minutes and starts 1000 threads to insert 500 buckets (500_000 buckets all
together) it's more like an integration test and would be better to move the
slowest part to the integration-test project.
{quote}
I think now it should run quickly with the fix, and also I think it will not
take that much of time. On my local laptop, I see, it is always completed in
30sec.
And on github run I see it is completed in 53 seconds. I just want to keep this
test in UT, as this will detect any failure in the DoubleBuffer issue which is
a critical component in OM. (Why I want in UT, because we are going to force
sooner, UT should be always green)
[INFO] Running
org.apache.hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse
[1164|https://github.com/bharatviswa504/hadoop-ozone/runs/308637202#step:3:1164][INFO]
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 53.536 s - in
org.apache.hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse
> TestOzoneManagerDoubleBufferWithOMResponse is flaky
> ---------------------------------------------------
>
> Key: HDDS-2535
> URL: https://issues.apache.org/jira/browse/HDDS-2535
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Manager
> Reporter: Marton Elek
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Flakiness can be reproduced locally. Usually it passes, but when I started to
> run it 100 times parallel with high cpu load it failed with the 3rd attempt
> (timed out)
> {code:java}
> -------------------------------------------------------------------------------
> Test set:
> org.apache.hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse
> -------------------------------------------------------------------------------
> Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 503.297 s <<<
> FAILURE! - in
> org.apache.hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse
> testDoubleBuffer(org.apache.hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse)
> Time elapsed: 500.122 s <<< ERROR!
> java.lang.Exception: test timed out after 500000 milliseconds
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:382)
> at
> org.apache.hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse.testDoubleBuffer(TestOzoneManagerDoubleBufferWithOMResponse.java:385)
> at
> org.apache.hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse.testDoubleBuffer(TestOzoneManagerDoubleBufferWithOMResponse.java:129)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
> {code}
> Independent from the flakiness I think a test where the timeout is 8 minutes
> and starts 1000 threads to insert 500 buckets (500_000 buckets all together)
> it's more like an integration test and would be better to move the slowest
> part to the integration-test project.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
