[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979244#comment-16979244
]
Jinglun commented on HDFS-14908:
--------------------------------
Hi [~weichiu] , thanks your comments ! Agree your way would be much simpler in
code and easier to be understood. But there was also a concern about the
overhead, like [~elgoiri] said
{quote}The other thing is that this will be called pretty frequently in the
LeaseManager.
{quote}
When we call listOpenFiles() all the open files in NameNode would be scanned
and compared. That would be very frequent. I think the new way would cost more.
> LeaseManager should check parent-child relationship when filter open files.
> ---------------------------------------------------------------------------
>
> Key: HDFS-14908
> URL: https://issues.apache.org/jira/browse/HDFS-14908
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.0.1
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Minor
> Attachments: HDFS-14908.001.patch, HDFS-14908.002.patch,
> HDFS-14908.003.patch, HDFS-14908.004.patch, HDFS-14908.005.patch, Test.java,
> TestV2.java, TestV3.java
>
>
> Now when doing listOpenFiles(), LeaseManager only checks whether the filter
> path is the prefix of the open files. We should check whether the filter path
> is the parent/ancestor of the open files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
