[ 
https://issues.apache.org/jira/browse/HDFS-13617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980110#comment-16980110
 ] 

Steve Loughran commented on HDFS-13617:
---------------------------------------

no worries here because (a) its done and (b) you've moved the main change into 
HDFS code with just some opened up accessors

If it was still in Token I'd be asking for that hadoop- JIRA and wanting to 
know how you were verify that it addressed backwards compatibility with every 
existing client which was sharing, saving & loading tokens...as I suspect here 
the answer would be "it doesn't"

You need to make sure that block tokens are compatible here. At the very least, 
save a Hadoop 3.2 BT to a file in test/resources and verify that you can reload 
it -something you can do in a JUnit test. Then save a block token to a file 
from trunk and (manually) verify that a hadoop-3.2 client can load it. Or 
better: bring up a cluster with this enhancement and then verify that a 
hadoop-3.2 client can work with HDFS. 



> Allow wrapping NN QOP into token in encrypted message
> -----------------------------------------------------
>
>                 Key: HDFS-13617
>                 URL: https://issues.apache.org/jira/browse/HDFS-13617
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Major
>             Fix For: 3.3.0
>
>         Attachments: HDFS-13617.001.patch, HDFS-13617.002.patch, 
> HDFS-13617.003.patch, HDFS-13617.004.patch, HDFS-13617.005.patch, 
> HDFS-13617.006.patch, HDFS-13617.007.patch, HDFS-13617.008.patch, 
> HDFS-13617.009.patch
>
>
> This Jira allows NN to configurably wrap the QOP it has established with the 
> client into the token message sent back to the client. The QOP is sent back 
> in encrypted message, using BlockAccessToken encryption key as the key.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to