[
https://issues.apache.org/jira/browse/HDFS-15023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984739#comment-16984739
]
Ayush Saxena commented on HDFS-15023:
-------------------------------------
Thanx [~ferhui], did you change the fix here?
Wasn't it checking not Observer? That was more descriptive, if that is APT, you
can add a line of comment also explaining the reason.
Is it possible to cover the change by a test?
> [SBN read] ZKFC should check the state before joining the election
> ------------------------------------------------------------------
>
> Key: HDFS-15023
> URL: https://issues.apache.org/jira/browse/HDFS-15023
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Fei Hui
> Assignee: Fei Hui
> Priority: Major
> Attachments: HDFS-15023.001.patch
>
>
> As discussed HDFS-14961, ZKFC should not join election when its state is
> observer.
> Right now when namemode was an observer, it joined election and it would be
> become a standby.
> MonitorDaemon thread callchain is that
> doHealthChecks -> enterState(State.SERVICE_HEALTHY) -> recheckElectability()
> -> elector.joinElection(targetToData(localTarget)) -> joinElectionInternal ->
> createLockNodeAsync
> callBack for zookeeper
> processResult -> becomeStandby
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
