[
https://issues.apache.org/jira/browse/HDFS-15028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988717#comment-16988717
]
Masatake Iwasaki commented on HDFS-15028:
-----------------------------------------
Thanks for the update, [~hadoop_yangyun].
* {{fixed.sized.volume}} or {{fixed.volume.size}} sounds natural for me rather
than {{fixed.size.volume}}.
* You must update hdfs-default.xml too when you add configuration properties.
* The checkstyle warning must be addressed: "public void
setCapacityForTesting(long capacity) {:42: 'capacity' hides a field.
[HiddenField]"
* I prefer field name like {{cachedCapacity}} to {{capacity}} in order to make
the intent clear.
* You should avoid wildcard import like {{import static
org.mockito.Mockito.*}};
* Please remove indentation/whitespace change of lines irrelevant to this
issue. It makes investigating past changes by {{git blame}} difficult.
> Keep the capacity of volume and reduce a system call
> ----------------------------------------------------
>
> Key: HDFS-15028
> URL: https://issues.apache.org/jira/browse/HDFS-15028
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Yang Yun
> Assignee: Yang Yun
> Priority: Minor
> Attachments: HDFS-15028.patch, HDFS-15028.patch, HDFS-15028.patch
>
>
> The local volume is not changed. so keep the first value of the capacity and
> reuse for each heartbeat．
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
